Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

chakrashim: enable building with Node ICU on Linux #215

Merged
merged 1 commit into from
Apr 18, 2017
Merged

chakrashim: enable building with Node ICU on Linux #215

merged 1 commit into from
Apr 18, 2017

Conversation

joaocgreis
Copy link
Member

#185 enabled using Node ICU on OSX. This PR follows with Linux support.

@kunalspathak @digitalinfinity this PR is necessary to use the Linux CI job. OK to fast-track if this looks good to you?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Chakrashim

@joaocgreis
Copy link
Member Author

CI: https://ci.nodejs.org/view/All/job/chakracore-test-pull-request/2/ (3 failed tests seem to be flaky and not related to this PR)

@digitalinfinity
Copy link
Contributor

@joaocgreis ok to merge from my side. @obastemur FYI

@obastemur
Copy link
Contributor

LGTM

@joaocgreis
chakrashim: enable building with Node ICU on Linux
5bd7d4d 
PR-URL: nodejs#215
Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
Reviewed-By: Oguz Bastemur <ogbastem@microsoft.com>
@joaocgreis joaocgreis force-pushed the joaocgreis-H4H-icu-linux branch from e26b1cf to 5bd7d4d Compare April 18, 2017 11:20
@joaocgreis joaocgreis merged commit 5bd7d4d into nodejs:xplat Apr 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@digitalinfinity digitalinfinity digitalinfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joaocgreis @digitalinfinity @obastemur