Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
chakrashim: enable building with Node ICU on Linux
Browse files Browse the repository at this point in the history
PR-URL: #215
Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
Reviewed-By: Oguz Bastemur <ogbastem@microsoft.com>
  • Loading branch information
joaocgreis committed Apr 18, 2017
1 parent 481ca0e commit 5bd7d4d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions deps/chakrashim/chakracore.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
'msvs_windows_target_platform_version_prop':
'/p:WindowsTargetPlatformVersion=$(WindowsTargetPlatformVersion)',
}],
['OS=="mac"', {
['OS!="win"', {
'icu_include_path': '../<(icu_path)/source/common'
}],

Expand All @@ -42,7 +42,7 @@
'type': 'none',

'conditions': [
['OS=="mac"', {
['OS!="win"', {
'dependencies': [
'<(icu_gyp_path):icui18n',
'<(icu_gyp_path):icuuc',
Expand Down Expand Up @@ -78,11 +78,11 @@
'chakracore_binaries': [
'<(chakra_libs_absolute)/lib/libChakraCoreStatic.a',
],
'icu_args': '--icu=<(icu_include_path)',
'linker_start_group': '-Wl,--start-group',
'linker_end_group': [
'-Wl,--end-group',
'-lgcc_s',
'-licuuc',
]
}],
['OS=="mac"', {
Expand Down

0 comments on commit 5bd7d4d

Please sign in to comment.