This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
n-api: fix TypedAarray info for ArrayBuffer offset
The JsGetTypedArrayStorage API returns a buffer pointer that already incorporates the offset into the ArrayBuffer, so adding the offset was a mistake. This bug was caught by the N-API C++ wrapper tests at https://github.com/nodejs/node-addon-api/blob/master/test/typedarray.js PR-URL: #259 Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Kunal Pathak <kpathak@microsoft.com> Reviewed-By: Taylor Woll <taylor.woll@microsoft.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
- Loading branch information