Use built-in N-API on Node.js >= 6.14.2 #263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the version ranges in index.js to reflect that N-API is now available in Node.js 6.x as of v6.14.2.
|
CIs: Node v5.x: https://ci.nodejs.org/job/node-test-node-addon-api/280/ |
kfarnung
approved these changes
May 4, 2018
digitalinfinity
approved these changes
May 4, 2018
|
@cjihrig should node 9.x and earlier work on smartos17 or just 10.X and later. I'm guessing the failures on 9.X and 8.x for smartos17 are just because we should not be running there. |
|
That's my understanding, per nodejs/build#1228. |
|
Thanks, fixed the CI job had a small bug in selection of platforms. Otherwise, CI looks good so landing. |
gabrielschulhof
pushed a commit
that referenced
this pull request
May 8, 2018
Update the version ranges in index.js to reflect that N-API is now available in Node.js 6.x as of v6.14.2. PR-URL: #263 Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
Landed in 437514e. |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Update the version ranges in index.js to reflect that N-API is now available in Node.js 6.x as of v6.14.2. PR-URL: nodejs/node-addon-api#263 Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Update the version ranges in index.js to reflect that N-API is now available in Node.js 6.x as of v6.14.2. PR-URL: nodejs/node-addon-api#263 Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Update the version ranges in index.js to reflect that N-API is now available in Node.js 6.x as of v6.14.2. PR-URL: nodejs/node-addon-api#263 Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Update the version ranges in index.js to reflect that N-API is now available in Node.js 6.x as of v6.14.2. PR-URL: nodejs/node-addon-api#263 Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the version ranges in index.js to reflect that N-API is
now available in Node.js 6.x as of v6.14.2.