Add test coverage for typed and range err #1280
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR aims to close #981, #984 and #1271.
Adds test for
TypeError
andRangeError
, as well as some validation logic for thenapi_value
object we pass to the baseTypeError
andRangeError
ctor. The question is whether we want to crash the application when thenapi_value
passed isn't a jsTypeError
, or if we want to emit some type of warning instead.