-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new items to ToDo list & add links to PRs #79
Conversation
Do we want to distinguish between future items we're planning on doing and others that are tentative? Not sure if we have any tentative ones in this list though. Losing the headings means we have no way to indicate an “in progress” item. We should add an item for helper functions to reduce boilerplate. It's implied by the conclusion paragraph but since that was written I think we know we want to do that in some form. |
Sure :) Cross that bridge when we come to it?
It'll have a PR link and not be checked off. Is that too subtle? (We also have a project in the nodejs/node repo)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last paragraph repeats about the thread but this is fine.
Oh, actually now that you mention it, didn't Bradley already implement the channel communication thing? I'm thinking we just axe both of those from the final paragraph. |
Not that I'm aware of? You can look at landed PRs that he's authored. |
Pretty sure that a communication channel is already exposed to |
Yes, exactly what I was thinking of (here's the PR nodejs/node#39240) |
No description provided.