Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Action capabilities #11

Merged
merged 9 commits into from
Feb 21, 2023

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Feb 21, 2023

Main changes

Added Github Actions capabilities

  • Added build step as NPM Script (0261b10)
  • Added @actions/core as dependency (0261b10)
  • Added @vercel/ncc as dev Dependency (0261b10)
  • Changed git ignore rules to include /dist/** folder in the repo (09f5a83)
  • Added action main logic action.js (09f5a83)
  • Added action metadata action.yml (09f5a83)
  • Added /dist folder (09f5a83)
  • Added ignore rule for /dist in the linter (702ad81)
  • Added build step to CI (a26c424)

Demo

  • Passing for Node.js 18.14.1, Node.js Vulnerabilities (PASS)
  • Failing for Node.js 8.0.0, Node.js Vulnerabilities (FAIL)

Notes

It is important to notice that /dist folder needs to be updated when doing a release in order to ship the changes to the Github Action itself, as the function is using the dist/index.js as entry point.

Changelog

@UlisesGascon UlisesGascon marked this pull request as ready for review February 21, 2023 09:00
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@RafaelGSS RafaelGSS merged commit d82eaf0 into nodejs:main Feb 21, 2023
@UlisesGascon UlisesGascon deleted the feat/ga-capabilities branch March 17, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants