Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yarn to v0.23.4 #390

Merged
merged 1 commit into from
May 3, 2017
Merged

Update yarn to v0.23.4 #390

merged 1 commit into from
May 3, 2017

Conversation

PeterDaveHello
Copy link
Member

No description provided.

@Starefossen Starefossen requested a review from chorrell May 2, 2017 20:32
@pesho
Copy link
Contributor

pesho commented May 2, 2017

Please take a look at the discussion starting at #386 (comment)

We should probably stick to updating Yarn only together with new Node releases.

@chorrell
Copy link
Contributor

chorrell commented May 3, 2017

So I guess we can close this for #389 since it already has the yarn update along with the Node.js updates for v4 and v6

@chorrell
Copy link
Contributor

chorrell commented May 3, 2017

Actually never mind. I see #389 was already updated to remove the yarn updates

chorrell

This comment was marked as off-topic.

@chorrell chorrell merged commit 68ec46d into nodejs:master May 3, 2017
@pesho
Copy link
Contributor

pesho commented May 3, 2017

Actually never mind. I see #389 was already updated to remove the yarn updates

However, the current PR also updates Yarn in branches which have no new release.

@chorrell
Copy link
Contributor

chorrell commented May 3, 2017

Oh, well, crap.

I'll do a PR that reverts the change for v7.

@chorrell
Copy link
Contributor

chorrell commented May 3, 2017

See #391

If I can get a quick approval I'll merge. I can do the Docker Hub PR but if someone else wants to take that on that would be great.

@pesho
Copy link
Contributor

pesho commented May 3, 2017

I can do the Docker Hub PR but if someone else wants to take that on that would be great.

@chorrell no problem, I'll handle it.

@pesho
Copy link
Contributor

pesho commented May 3, 2017

Upstream PR: docker-library/official-images#2919

@razor-x
Copy link
Contributor

razor-x commented May 7, 2017

I was really hoping yarn 0.24.x would make it in time for node 6.10.3. Keep in mind I like keeping the yarn version relatively stable in each node release, but the original issue I had that brought that up was because yarn was updated from 0.22.0 to 0.23.x which broke things: 0.24.x contains fixes to regressions I've been waiting on.

Anyway, if 0.23.x is going to be in node 6.10.3 and I have to wait another month or so for yarn 0.24.x, then I would really appreciate seeing at least #381 merged in to fix the 6.10.3 image (and all the other images that use yarn < 0.24.x which would be affected).

That is the last major regression I'm dealing with and it should IMO be patched in the images which will never get the fix from the newer yarn versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants