-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept revert commit titles that are elongated by git #97
Comments
I think we used to restrict the title to 50 chars, which is conventional and works well with other tools, but now that the limit is softer, this can happen. So I guess the only solution is indeed to also relax this limit, but probably only if it matches |
RaisinTen
added a commit
to RaisinTen/core-validate-commit
that referenced
this issue
Jun 26, 2022
This change ensures that the commit message linter doesn't reject revert commits that originally had commit titles with an acceptable length but were elongated during the revert process by running `git revert`. Fixes: nodejs#97 Signed-off-by: Darshan Sen <raisinten@gmail.com>
Agreed, sent a PR to implement this - #99 |
RaisinTen
added a commit
to RaisinTen/core-validate-commit
that referenced
this issue
Jun 26, 2022
This change ensures that the commit message linter doesn't reject revert commits that originally had commit titles with an acceptable length but were elongated during the revert process by running `git revert`. Fixes: nodejs#97 Signed-off-by: Darshan Sen <raisinten@gmail.com>
RaisinTen
added a commit
that referenced
this issue
Jul 3, 2022
This change ensures that the commit message linter doesn't reject revert commits that originally had commit titles with an acceptable length but were elongated during the revert process by running `git revert`. Fixes: #97 Signed-off-by: Darshan Sen <raisinten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In nodejs/node#42934, I was trying to revert nodejs/node#27371, so
git revert
automatically created this commit title for me:which has 74 characters. Since it exceeds our maximum limit of 72 characters, the commit message linter failed on CI - https://github.com/nodejs/node/runs/6248053065?check_suite_focus=true#step:6:15
As a workaround, I had to change the commit title to
which has 69 characters (< 72) but it isn't satisfying anymore. :/
Instead of failing, IMO the linter should accept standard revert commit titles regardless of the size.
The text was updated successfully, but these errors were encountered: