Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: skip eslint-plugin-jest on big endian platforms #834

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

richardlau
Copy link
Member

eslint-plugin-jest uses yarn policies which uses emscripten which
only supports little endian architectures.

Refs: #824 (comment)

Checklist
  • npm test passes
  • contribution guidelines followed
    here

eslint-plugin-jest uses yarn policies which uses emscripten which
only supports little endian architectures.
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2020

Codecov Report

Merging #834 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #834   +/-   ##
=======================================
  Coverage   96.05%   96.05%           
=======================================
  Files          31       31           
  Lines         913      913           
=======================================
  Hits          877      877           
  Misses         36       36           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2428c1...0d58cf6. Read the comment docs.

@richardlau richardlau merged commit b1f839a into nodejs:main Sep 29, 2020
@richardlau richardlau deleted the skip-eslint-plugin-jest branch September 29, 2020 21:23
@SimenB
Copy link
Member

SimenB commented Sep 29, 2020

All yarn@2 should skip, no? Doesn't seem like a package-specific thing

@richardlau
Copy link
Member Author

All yarn@2 should skip, no? Doesn't seem like a package-specific thing

I'm not aware of any other package in CITGM's lookup using yarn2.

@SimenB
Copy link
Member

SimenB commented Sep 29, 2020

Sure, but that'll (probably?) change, at which point targeting yarn makes more sense than specific modules

@richardlau
Copy link
Member Author

Sure, but that'll (probably?) change, at which point targeting yarn makes more sense than specific modules

I'd rather cross that bridge when we get to it. For now all skips are explicit in the lookup. Skipping for yarn2 requires code changes to CITGM.

@SimenB SimenB mentioned this pull request Oct 20, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants