-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lookup: unskip ws on win32 #607
Conversation
It seems citgm-smoker-nobuild does not work. Trying with citgm-smoker. CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1569/ |
@nodejs/citgm Is there anything I can do to move this and #608 forward? |
Results are good on Node 10 and 11 but the job fails to run on 6 and 8 (opened nodejs/build#1602) |
Running citgm-smoker instead: |
5aa1f50
to
8c35a13
Compare
hey @lpinca the pipeine job you tried to run was running for almost 10 hours so I aborted it. Lets dig in and figure out what was taking so long. I think it is that the AIX machine is out of memory /cc @nodejs/build |
Ok, there is also something wrong in the Windows machines.
|
8c35a13
to
3720059
Compare
Codecov Report
@@ Coverage Diff @@
## master #607 +/- ##
=======================================
Coverage 94.52% 94.52%
=======================================
Files 27 27
Lines 876 876
=======================================
Hits 828 828
Misses 48 48 Continue to review full report at Codecov.
|
3720059
to
db76de6
Compare
db76de6
to
4dfda8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI is green
Unskip ws on Windows.
Checklist