Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin: add citgm-all #27

Closed
wants to merge 0 commits into from
Closed

Conversation

MylesBorins
Copy link
Contributor

This PR adds a new bin to the project citgm-all

By default citgm-all will run the test suite of every package in the lookup table. If a custom lookup table is provided it will iterate across that instead.

TODO:

  • add more modules to the lookup table
  • ensure every package in lookup works(ish)
  • testing: unit testing with tap #26 needs to land
  • discuss running in parallel instead of series
  • a potential memory leak has been exposed
  • update documentation

@MylesBorins
Copy link
Contributor Author

Express failed:

Looks like the test suite for 4.13.3 fails on the current stable node (5.1)
Master passes

Chalk failed:

Test suite is only failing inside of citgm. It looks like the color data that chalk is appending the strings is getting lost at some point. I assume this is because it is running in a child process. Will investigate #28

the project npm-run-all implemented this fix to keep colors on internal processes

mysticatea/npm-run-all@736dee0

It look like there needs to be a refactor of how we handle spawning processes, and how we spawn npm commands. There appears to be quite a bit of overlap between npm-run-all and citgm, perhaps we can borrow some from that project (license is MIT)

Colors failed

See above

bluebird failed

TypeError: process.stdout.cursorTo is not a function

Looks like some more weirdness with stdout, likely making assumptions that it is running top level

yeoman-generator

I think we likely want to be tracking yo, which is the cli tool, rather than yeoman-generator. The tests are failing regardless.

Test suite on Master fails too. Looks like we found a breaking change :D

redis fails

don't have redis setup 📦

jquery fails
the test suite for jquery 2.1.4 is failing on node 5.1. Master passes

handlebars fails

v4.0.5
Fatal error: 1 tests failed
(node) sys is deprecated. Use util instead.

master
Error: ENOENT: no such file or directory, scandir '/Users/thealphanerd/code/handlebars.js/spec/mustache/specs/'

Looks like handlebars is not doing so well right now :(

yosay

same problem as chalk

mime

AssertionError: 'audio/mp4' == 'audio/x-m4a'

Does not look related to node

@MylesBorins
Copy link
Contributor Author

/cc @jasnell

@jasnell
Copy link
Member

jasnell commented Nov 20, 2015

woo! awesome

@MylesBorins
Copy link
Contributor Author

reopening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants