serialport error with V8 5.4

[targos]

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/381/nodes=fedora23/testReport/junit/(root)/citgm/serialport_v4_0_1/

grunt: symbol lookup error: /tmp/1cfb2d13-7db2-423f-81fb-930025e9f739/serialport/build/Release/serialport.node: undefined symbol: _ZN2v816FunctionTemplate3NewEPNS_7IsolateEPFvRKNS_20FunctionCallbackInfoINS_5ValueEEEENS_5LocalIS4_EENSA_INS_9SignatureEEEi

[bnoordhuis]

That's v8::FunctionTemplate::New(v8::Isolate*, void (*)(v8::FunctionCallbackInfo<v8::Value> const&), v8::Local<v8::Value>, v8::Local<v8::Signature>, int) which still exists in 5.4, AFAIK.

[targos]

Here is the declaration: https://github.com/targos/node/blob/v8-5.4/deps/v8/include/v8.h#L4510-L4514

[MylesBorins]

/cc @reconbot

On Mon, Sep 12, 2016, 11:46 AM Michaël Zasso notifications@github.com
wrote:

Here is the declaration:
https://github.com/targos/node/blob/v8-5.4/deps/v8/include/v8.h#L4510-L4514

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#179 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAecV4v6-jrEb2ArCDO38dP4oHV2P_GMks5qpR-JgaJpZM4J6ZN9
.

[reconbot]

Do we have logs from the build/install stage of the test?

[targos]

Actually that may be related to node-pre-gyp.
I installed locally and got the same error but I saw that it somehow downloaded a pre-built version of serialport.node. It worked after a forced build from source.

[targos]

/cc @springmeyer

[reconbot]

Sounds like we've broken binary compatibility within a major release.

On Mon, Sep 12, 2016, 2:59 PM Michaël Zasso notifications@github.com
wrote:

/cc @springmeyer https://github.com/springmeyer

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#179 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABlbvV583Rg9FT_sgi95oPAUii2PMeJks5qpaEYgaJpZM4J6ZN9
.

[targos]

I think it happens because NODE_MODULE_VERSION is still 48. It will be bumped when v7.0.0 is released

[reconbot]

If that's the case then it's doing exactly what it should. That's how both node-pre-gyp and prebuilt work, match version numbers and download. I think there's value in testing precompiled binaries against new versions, because then we'll detect binary breakage within ABI versions. In this case however maybe we should also have a test that builds from source npm install --build-from-source is the way to go. I can't speak to the CITGM goals on this finer point. =)

[MylesBorins]

I have a version of citgm that can force rebuild... just hasn't landed on master as I still have to get some testing done.

https://github.com/thealphanerd/citgm/tree/rebuild

Here is a citgm run of v7.x (wtih v5.4 afaik) using the rebuild flag.
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/382/