Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to join the build WG #927

Merged
merged 1 commit into from
Oct 31, 2017
Merged

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Oct 21, 2017

Hi all, I have been asking for help a lot on the build IRC lately (regarding benchmark CI configurations and core CI jobs). Had a chat with @refack and I was suggested to join the working group. I'd love to get more involved.

cc @nodejs/build

refack

This comment was marked as off-topic.

@refack
Copy link
Contributor

refack commented Oct 21, 2017

🎉 👏

gibfahn

This comment was marked as off-topic.

@gibfahn
Copy link
Member

gibfahn commented Oct 21, 2017

+1 on this landing, but @joyeecheung if you'd like to work on anything in the mean time, please let us know.

@joyeecheung
Copy link
Member Author

joyeecheung commented Oct 22, 2017

@gibfahn I am thinking about the continuation of #887 , a CI job for make lint and doc tests? (see nodejs/node#16208 (comment)). I will open a issue for that.

EDIT: issue opened at #929

mhdawson

This comment was marked as off-topic.

joaocgreis

This comment was marked as off-topic.

@gibfahn
Copy link
Member

gibfahn commented Oct 27, 2017

@nodejs/build If there are no objections I think we should consider this settled. Does anyone have time to do an onboarding for @joyeecheung ? We might be able to combine it with one for @maclover7 (#928).

I'd like to help out with the onboarding, but not comfortable leading it.

@refack
Copy link
Contributor

refack commented Oct 27, 2017

I'd also love to help with onboarding (also don't mind leading if no one else is available)

@joyeecheung
Copy link
Member Author

Rebased.

@refack @gibfahn I'd be happy to get onboard with @maclover7 if we can find a time that works for all of us.

@joaocgreis
Copy link
Member

I can also join if you'd like me to, but my availability isn't so great at the moment so feel free to go ahead @gibfahn @refack . Ping me to add to the build team in the day before or so.

Welcome @joyeecheung and @maclover7 !

@gibfahn gibfahn merged commit 8cafabf into nodejs:master Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants