Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible: improve Python 3 compatibility #1929

Merged
merged 2 commits into from
Sep 27, 2019
Merged

ansible: improve Python 3 compatibility #1929

merged 2 commits into from
Sep 27, 2019

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 27, 2019 •
edited
Loading

As requested at #1399 (comment), this PR cherrypicks key modifications from #1399 to improve the Python 3 compatibility of our build process.

  • git checkout refack/pipenv+python3 -- .flake8 .gitignore ansible/plugins/library/remmina_config.py ansible/plugins/library/ssh_config.py setup/www/tools/metrics/country-lookup.py jenkins/scripts/coverage/generate-index-html.py
  • code ansible/plugins/inventory/nodejs_yaml.py
  • flake8 . # placate flake8

@cclauss cclauss mentioned this pull request Sep 27, 2019
Merged
sam-github
sam-github suggested changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@sam-github sam-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM on the python changes, I assume they don't change anything, a bit worried by the change to the archs.

ansible/plugins/inventory/nodejs_yaml.py Outdated Show resolved Hide resolved
jenkins/scripts/coverage/generate-index-html.py Outdated Show resolved Hide resolved
.flake8 Outdated Show resolved Hide resolved
@sam-github
Copy link
Contributor

Out of curiosity, is flake8 run by anything in our tooling? I'd never heard of it till this PR.

@cclauss
Copy link
Contributor Author

cclauss commented Sep 27, 2019 •
edited
Loading

flake8 can be found as the guardrails for pretty much every repo that I touch. In Node.js land:

Trott
Trott approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

mhdawson
mhdawson approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Trott Trott merged commit 2920347 into nodejs:master Sep 27, 2019
@cclauss cclauss deleted the improve-Python3-compat branch September 27, 2019 20:28
rvagg pushed a commit that referenced this pull request Sep 30, 2019
@cclauss @rvagg
build: on push GitHub Action to lint Python code
303e626 
Blocked by: #1929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@Trott Trott Trott approved these changes

@sam-github sam-github sam-github approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cclauss @sam-github @Trott @mhdawson