-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add SECURITY_WG_GITHUB_TOKEN request #950
Conversation
3ee80a5
to
475ad9c
Compare
To whoever who lands this: careful, the token should be saved on the nodejs-private/security-release, not on the public repo – I mean, I guess we can save it on the public repo as well, but currently it's not necessary. @RafaelGSS am I understanding things correctly? Side node: maybe the current table is not well fitted for this kind of "cross-repo tokens". /cc @legendecas |
Correct |
For additional repo permissions, we can list the request in the PR description. The table should list where the token is installed, so that we can rotate the token by the table. |
Co-authored-by: Chengzhong Wu <cwu631@bloomberg.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I believe I've added the token as requested |
Refs: #949