Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update request-an-access-token.md #926

Merged
merged 8 commits into from
Oct 29, 2024
Merged

Update request-an-access-token.md #926

merged 8 commits into from
Oct 29, 2024

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Oct 21, 2024

The requested token should have the following permissions:

permissions:
  contents: write
  pull-requests: write
https://github.com/googleapis/release-please-action?tab=readme-ov-file#workflow-permissions

--- | --- | --- | --- |
[`nodejs/import-in-the-middle`][] | `RELEASE_PLEASE_GITHUB_TOKEN` | 2025-07-23 | <https://github.com/nodejs/admin/pull/902> |
[`nodejs/node-core-utils`][] | `RELEASE_PLEASE_GITHUB_TOKEN` | 2025-09-01 | <https://github.com/nodejs/admin/pull/915> |
[`nodejs/wasm-builder`][] | `RELEASE_PLEASE_GITHUB_ACTION` | 2025-10-01 | <https://github.com/nodejs/admin/pull/926> |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reference [`nodejs/wasm-builder`] isn't defined at the bottom of the document

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nschonni thanks for catching that added, although the link will not work until the repo is transferred as discussed in #927

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem.
PS, the diff would be smaller if this repo used the same ending of TOKEN instead of ACTION

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but that is a bigger change than just chaging in this repo. As I move over the repo I'll consider doing that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@mhdawson
Copy link
Member Author

@nodejs/tsc would be great to get an approval so that I can land this.

@legendecas legendecas merged commit e8fa61f into main Oct 29, 2024
@legendecas legendecas deleted the mhdawson-patch-1 branch October 29, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants