Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass a context to napi_finalize #111

Closed
gabrielschulhof opened this issue Feb 22, 2017 · 1 comment
Closed

Pass a context to napi_finalize #111

gabrielschulhof opened this issue Feb 22, 2017 · 1 comment
Assignees
@digitalinfinity @jasongin
Milestone
Milestone 6 (PR S...

Comments

@gabrielschulhof
Copy link
Collaborator

Let's modify napi_finalize to take a context as its second parameter as suggested in #109 (comment).
@gabrielschulhof gabrielschulhof mentioned this issue Feb 22, 2017
Closed
@digitalinfinity digitalinfinity self-assigned this Mar 14, 2017
@digitalinfinity digitalinfinity mentioned this issue Mar 16, 2017
Merged
digitalinfinity added a commit that referenced this issue Mar 16, 2017
@digitalinfinity
napi: add finalize hint support (#155)
7597d8e 
napi: add finalize hint support

Change napi_finalize_callback to support a hint parameter
APIs that take in a finalize callback now also take a hint
This hint is passed back in when the finalize callback is
called

Fixes: #111 
Reviewed-By: @jasongin @boingoing @mhdawson 
PR-Url: #155
@digitalinfinity
Copy link
Contributor

Fixed in 7597d8e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@digitalinfinity digitalinfinity

@jasongin jasongin

Labels
None yet
Projects
None yet
Milestone
Milestone 6 (PR Submission)
Development

No branches or pull requests
4 participants
@digitalinfinity @gabrielschulhof @aruneshchandra @jasongin