Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it me or when I updated to 2.11.0 Dashboard and node-red 19.5 the tab names no longer appear in the title bar? #453

Closed
6 tasks
marksmanaz opened this issue Dec 3, 2018 · 6 comments

Comments

@marksmanaz
Copy link

What are the steps to reproduce?

What happens?

What do you expect to happen?

Please tell us about your environment:

  • Node-RED-Dashboard version:
  • Node-RED version:
  • node.js version:
  • npm version:
  • Platform/OS:
  • Browser:
@dceejay dceejay closed this as completed in 6b6d716 Dec 3, 2018
@dceejay
Copy link
Member

dceejay commented Dec 3, 2018

ooops... will be back imminently...

@marksmanaz
Copy link
Author

Sorry to say but that put the tab name in the title bar along with the title. From what I remember Tabs had their own bar secondary under the title bar.

@marksmanaz
Copy link
Author

capture

@marksmanaz
Copy link
Author

I guess this would be fine if you could make the Tab name come after the Tile name and have a space between them

@dceejay
Copy link
Member

dceejay commented Dec 6, 2018

Ok - now aiming for this

image

So when in the mode to always show the sidebar the title is used and the selected tab is indicated.
And when in hidden sidebar mode the title is the tab name as before.

@marksmanaz
Copy link
Author

Sounds good to me, thank you

dceejay pushed a commit that referenced this issue Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants