Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safe default filename #689

Merged
merged 34 commits into from
Mar 18, 2021
Merged

Safe default filename #689

merged 34 commits into from
Mar 18, 2021

Conversation

GrosSacASac
Copy link
Contributor

@GrosSacASac GrosSacASac commented Feb 18, 2021 •
edited
Loading

@tunnckoCore Changed a bit how filename works (read the commit messages to get an overview)

fixes #672, #671, #389, #596, #465, #358

@pr-triage pr-triage bot added the PR: draft label Feb 18, 2021
@GrosSacASac GrosSacASac marked this pull request as ready for review February 18, 2021 21:21
tunnckoCore
tunnckoCore previously approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@tunnckoCore tunnckoCore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

So now we only have filename and mime, right? Cool.

I'm more for calling it mimetype instead (plus it's same length as filename so.. haha), but you decide.

src/Formidable.js Outdated Show resolved Hide resolved
test/unit/persistent-file.test.js Outdated Show resolved Hide resolved
test/unit/volatile-file.test.js Outdated Show resolved Hide resolved
tunnckoCore
tunnckoCore reviewed Feb 19, 2021
View reviewed changes
src/Formidable.js Outdated Show resolved Hide resolved
tunnckoCore
tunnckoCore reviewed Feb 19, 2021
View reviewed changes
src/Formidable.js Outdated Show resolved Hide resolved
@GrosSacASac GrosSacASac requested a review from tunnckoCore March 2, 2021 12:51
@GrosSacASac
Copy link
Contributor Author

@illl48 @davidstrouk, @ololoepepe , @mclark-newvistas please try it out

npm i github:node-formidable/formidable#safe-default-filename

@GrosSacASac GrosSacASac mentioned this pull request Mar 3, 2021
Merged
tunnckoCore
tunnckoCore previously approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@tunnckoCore tunnckoCore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good i think, will review it again in the weekend.

@GrosSacASac
Copy link
Contributor Author

Once this is merged we can open a PR for https://github.com/node-formidable/formidable/tree/filter-upload which helps to filter files before they are uploaded

@GrosSacASac
Copy link
Contributor Author

fixes #648

@GrosSacASac GrosSacASac mentioned this pull request Mar 11, 2021
Closed
@GrosSacASac
Copy link
Contributor Author

@tunnckoCore Can we merge it ?

@GrosSacASac GrosSacASac mentioned this pull request Mar 17, 2021
Open
@tunnckoCore
Copy link
Member

@tunnckoCore Can we merge it ?

yep, i think so, sorry for not responding after the last review.

ii think we are close to v2 after this, what you think?

@GrosSacASac
Copy link
Contributor Author

I agree

@GrosSacASac GrosSacASac merged commit 748f1db into master Mar 18, 2021
@GrosSacASac GrosSacASac deleted the safe-default-filename branch March 18, 2021 14:57
@karlhorky karlhorky mentioned this pull request Apr 4, 2021
Closed
@redevill redevill mentioned this pull request May 8, 2023
Closed
@jackycute jackycute mentioned this pull request Aug 10, 2023
Closed
@jfirebaugh jfirebaugh mentioned this pull request Apr 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tunnckoCore tunnckoCore tunnckoCore left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better consistency of name, filename, type, mime, options and pass more to fileWriteHandler
2 participants
@GrosSacASac @tunnckoCore