Fixing some tests that failed on systems that do not have UTF8 as the default charset #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arset-other-than-utf8
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #118 +/- ##
=========================================
Coverage 92.18% 92.18%
Complexity 381 381
=========================================
Files 27 27
Lines 973 973
Branches 87 87
=========================================
Hits 897 897
Misses 58 58
Partials 18 18 ☔ View full report in Codecov by Sentry. |
|
Looks good, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my machine, some tests failed because the test result was written to the tmp folder using the Latin-1 (ISO-8859-1) character set, but later read using UTF8.
This PR ensures that the test result is always written to the file using UTF8, regardless of the system's default character set.