Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handbook translation in fr-FR #288

Merged
merged 36 commits into from
Jan 19, 2025
Merged

Handbook translation in fr-FR #288

merged 36 commits into from
Jan 19, 2025

Conversation

dracito
Copy link
Contributor

@dracito dracito commented Jan 12, 2025

No description provided.

@dracito dracito changed the title Handbook tranlation in fr-FR Handbook translation in fr-FR Jan 12, 2025
@dracito
Copy link
Contributor Author

dracito commented Jan 12, 2025

Partially resolve issue #269

@Albert-mah
Copy link
Collaborator

Albert-mah commented Jan 14, 2025

@dracito
Hi!

First of all, thank you so much for your extensive work translating our project documentation into French! This will greatly help our French-speaking users.

However, we've encountered a build error that needs your attention before we can merge the PR. The error message is as follows:
https://github.com/nocobase/docs/actions/runs/12737290913/job/35583206078?pr=288
image

It appears there's an extra single quote at the end of the string on line 256 in handbook.ts. Could you please take a look and correct this issue? Once fixed, please push the changes, and the build should proceed smoothly.

If you need any assistance or have questions about the error, feel free to reach out. We're here to help!

Thank you again for your valuable contribution. Looking forward to your updated PR.

Best regards,
Albert Ma

@dracito
Copy link
Contributor Author

dracito commented Jan 18, 2025

Thank you for your review 👍
Fix is done.

@Albert-mah Albert-mah merged commit 80b0e42 into nocobase:main Jan 19, 2025
@dracito dracito deleted the handbook branch January 25, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants