Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show map if transform is missing #51

Open
schra opened this issue Apr 29, 2019 · 3 comments
Open

Don't show map if transform is missing #51

schra opened this issue Apr 29, 2019 · 3 comments
Labels
enhancement

Comments

@schra
Copy link
Collaborator

schra commented Apr 29, 2019

If AerialMapDisplay/Status/Transform shows the error Fixed Frame [map] does not exist then the map shouldn't be drawn at all. This leads to confusing results, see #48
@beetleskin
Copy link
Contributor

Could be done by using MessageFilterDisplay, like most display plugins do.

schra pushed a commit that referenced this issue May 3, 2019
@AndreSchroeder-TomTom
Don't show map if transform is missing
09084e3 
It's confusing when the map is shown but the transform is missing. This
leads to the map being on a wrong place.

Fixes #51
@schra schra mentioned this issue May 3, 2019
Closed
@m-naumann
Copy link

I encountered the same while working on #55

The easiest would be to set scene_node->setVisible(false); but the problem I see is that there are cached tiles that are made invisible, and when setting scene_node->setVisible(true); after successful transformations, they are all set to true, so also old/irrelevant tiles are shown.

@m-naumann m-naumann mentioned this issue May 20, 2019
Closed
@beetleskin beetleskin mentioned this issue Apr 17, 2020
Merged
@schra
Copy link
Collaborator Author

schra commented Apr 28, 2020

From #72:

When you set an invalid ff, for example "asdfasdfsf", then the map will jump. (It will not jitter, but jump). The status shows that there is an error, but the map is still displayed. I think we should hide the map if the ff is invalid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't show map if transform is missing nobleo/rviz_satellite
3 participants
@beetleskin @m-naumann @schra