Fix coordinate messup when converting H3 entities to points. Fixes #58 (

#60)

* Fixed coordinate messup when converting H3 entities to points. Fixes #58

* call pytest as module

* maintain python 3.8 compatibility

* require fiona <1.10

.github/workflows/ci.yml

@@ -55,7 +55,7 @@ jobs:
         run: |
           set -e
           pip install --force-reinstall dist/*.whl
-          pytest -s h3ronpy/tests
+          python -m pytest -s h3ronpy/tests
 
   linux-aarch64:
     runs-on: ubuntu-latest
@@ -120,7 +120,7 @@ jobs:
         run: |
           set -e
           pip install --force-reinstall dist/*.whl
-          pytest h3ronpy/tests
+          python -m pytest h3ronpy/tests
 
   macos-x86_64:
     needs:
@@ -162,7 +162,7 @@ jobs:
       #  run: |
       #    set -e
       #    pip install --force-reinstall --verbose dist/*.whl
-      #    pytest h3ronpy/tests
+      #    python -m pytest h3ronpy/tests
 
   macos-aarch64:
     runs-on: macos-latest

crates/h3arrow/src/array/to_geo.rs

@@ -81,7 +81,7 @@ macro_rules! impl_iter_points {
                                 let pt: Point = if use_degrees {
                                     Coord {
                                         x: ll.lng(),
-                                        y: ll.lng(),
+                                        y: ll.lat(),
                                     }
                                     .into()
                                 } else {

h3ronpy/CHANGES.rst

@@ -12,6 +12,8 @@ Versioning <https://semver.org/spec/v2.0.0.html>`__.
 Unreleased
 ----------
 
+- Fixed coordinate messup when converting H3 entities to points (issue #58).
+
 0.21.0 - 2024-07-01
 -------------------
 

h3ronpy/pyproject.toml

@@ -37,6 +37,7 @@ polars = [
 ]
 pandas = [
     "geopandas>=0.10",
+    "fiona<1.10"
 ]
 test = [
     "rasterio",

h3ronpy/tests/arrow/test_vector.py

@@ -1,7 +1,8 @@
-from h3ronpy.arrow.vector import geometry_to_cells, ContainmentMode
+from h3ronpy.arrow.vector import geometry_to_cells, ContainmentMode, cells_to_wkb_points
 import pyarrow as pa
 import shapely
 from shapely.geometry import Point
+from shapely import wkb
 import h3.api.numpy_int as h3
 
 
@@ -20,3 +21,25 @@ def test_geometry_to_cells_central_park():
     arr = geometry_to_cells(point, 8).to_numpy()
     assert len(arr) == 1
     assert arr[0] == h3.geo_to_h3(point.y, point.x, 8)
+
+
+def test_coordinate_values_are_not_equal_issue_58():
+    # Step 1: Create a point (latitude and longitude)
+    lat, lon = 37.7749, -122.4194  # Example coordinates (San Francisco)
+    point = Point(lon, lat)  # shapely expects (longitude, latitude)
+
+    # Step 2: Convert the point to an H3 cell (resolution 9 for example)
+    resolution = 9
+    h3_cells = geometry_to_cells(point, resolution)
+
+    # Step 3: Convert the H3 cell back to WKB points
+    wkb_points = cells_to_wkb_points(h3_cells)
+
+    assert len(wkb_points) == 1
+
+    # Step 4: Decode the WKB point to a Shapely geometry
+    for wkb_point in wkb_points:
+        assert isinstance(wkb_point, pa.Scalar)  # Ensure it's a pyarrow Scalar
+        shapely_point = wkb.loads(wkb_point.as_buffer().to_pybytes())
+        assert int(lat) == int(shapely_point.y)
+        assert int(lon) == int(shapely_point.x)