fix issue#1989: only consider continuous numbers

[dota17]

In unflatten we just consider creating object, which means when we meet continuous numbers, we also unflatten to an object to represent the actual array. And then we convert those object with continuous numbers key to array.

#1989 (comment)

[coveralls]

Coverage increased (+0.0001%) to 99.941% when pulling 00cbf8a on dota17:unflatten into 5cfa8a5 on nlohmann:develop.

[dota17]

Please restart the job. It seems like a timeout error.

[dota17]

Keep alive.
Is there any new review or idea about this?

[nlohmann]

I am hesitant on this issue as it will break existing code in the sense that the unflattened values will differ.

[dota17]

the unflattened values will differ.

The problem is that the different Json values can be flattened to the same result. Thus, we can not know which one is the origin one.
For the ambiguous cases, we should take a clear rule to decide which one is preferred.

it will break existing code

Maybe unflatten is a sick funtion.
If we don't break, the origin function will still throw an exception for some scenarios that should be supported. Maybe we can clear the doc or comment to explain the abnormal situation.
Or add an option to keep the origin code. #1575 (comment)

Honestly, I don't know why the feature is included and which reference functions it is. The infos may help a lot.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.