Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken cmake imported target alias #1260

Merged
merged 3 commits into from
Oct 1, 2018
Merged

Fix broken cmake imported target alias #1260

merged 3 commits into from
Oct 1, 2018

Conversation

chuckatkins
Copy link
Contributor

@chuckatkins chuckatkins commented Sep 26, 2018 •
edited
Loading

This is a followup on #1245 in which the fix caused additional breakage. This PR does a more complete implementation of the package configs with version checking. It also adds a set of tests to make sure that other CMake projects can import and use the package config.

@chuckatkins chuckatkins force-pushed the fix-cmake-target-alias branch 3 times, most recently from 08e03ac to 00a63a8 Compare September 27, 2018 12:26
@chuckatkins chuckatkins changed the title Fix cmake target alias Fix broken cmake imported target alias Sep 27, 2018
@chuckatkins chuckatkins force-pushed the fix-cmake-target-alias branch from 00a63a8 to ea9ea94 Compare September 27, 2018 16:27
@nlohmann
Copy link
Owner

There are test cases failing for the Linux builds. @chuckatkins

@chuckatkins
Copy link
Contributor Author

Just saw that. I'll fix it today. That's great though, it means the tests are doing what they're supposed to be doing!

@nlohmann
Copy link
Owner

I'm looking forward to having this issue fixed - I could then make the next release.

@nlohmann nlohmann mentioned this pull request Sep 30, 2018
Closed
4 tasks
@chuckatkins chuckatkins force-pushed the fix-cmake-target-alias branch from ea9ea94 to fb246de Compare September 30, 2018 13:57
@coveralls
Copy link

coveralls commented Sep 30, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 02e653b on chuckatkins:fix-cmake-target-alias into 910a895 on nlohmann:develop.

@chuckatkins
Copy link
Contributor Author

@nlohmann This should be good to go now

@chuckatkins chuckatkins mentioned this pull request Sep 30, 2018
Merged
@chuckatkins chuckatkins force-pushed the fix-cmake-target-alias branch from fb246de to 02e653b Compare October 1, 2018 03:22
nlohmann
nlohmann approved these changes Oct 1, 2018
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Oct 1, 2018
@nlohmann nlohmann added this to the Release 3.3.0 milestone Oct 1, 2018
@nlohmann nlohmann merged commit c8231ef into nlohmann:develop Oct 1, 2018
@nlohmann
Copy link
Owner

nlohmann commented Oct 1, 2018

Thanks for the fix!

nlohmann referenced this pull request Oct 1, 2018
Use a version check to provide backwards comatible imported target na…
3b1a5ca 
…mes.
@nlohmann nlohmann mentioned this pull request Oct 1, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
None yet
Projects
None yet
Milestone
Release 3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chuckatkins @nlohmann @coveralls