-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conan.io #566
Comments
I think it's already there: https://www.conan.io/source/nlJson/2.0.2/arnemertz/stable That version is outdated. Would it make sense to add another one? |
Anyone can add to the conan's repository any library, but official supporting is always better. For example it could be uploaded from the CI at once and the conan's recipe could be adjusted properly by the developers and it could have correct naming and user in the canan's repository. |
@Pancir What exactly needs to be done for this? Is it sufficient to create a conanfile.py like this: https://github.com/arnemertz/conan-nlJson/blob/master/conanfile.py ? |
Yes and usually you have to create the test_package for checking the recipe. |
I just learned conan.io is deprecated. |
Yes, they just moved their public repository to another place. I don't learn the issue about this moving yet but I guess it should not affect the conanfile.py and the test_package. |
I am currently not planning to invest time into this. A PR would be appreciated. |
Sorry, I don't know what "PR" means. |
A pull request. If anyone would create the required files (such as https://github.com/nlohmann/json/blob/develop/meson.build for Meson, see #576), I would be happy to add them to my repository. |
Thx for the explanation. |
@Pancir As I described in #619, I cannot maintain Conan.io myself. If someone (like @arnemertz before) can maintain a repository with the required files, I would be happy. |
I shall leave this ticket open for a while. |
As discussed, I packaged the library (version 2.1.1) here conan-jsonformoderncpp and made it available on Bintray. |
Great. What should I add to the README (about 1 sentence) so that Conan users would know what to do? |
In the same spirit of what I proposed in #619 , I would suggest:
|
Thanks a lot! I shall update the README accordingly. |
Thank you guys! |
Hello guys I think it would be a good idea to make the library to be available through the conan. https://www.conan.io/
I could do it without your help but it is the better way when the developers is responsible for it themselves.
The text was updated successfully, but these errors were encountered: