Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added packing module. #3

Open
wants to merge 1 commit into
base: numba
Choose a base branch
from
Open

Added packing module. #3

wants to merge 1 commit into from

Conversation

dwieker
Copy link

@dwieker dwieker commented Nov 7, 2015

2D pair correlation function with edge handling.

@danielballan
Copy link

Oh, excellent! I have been hoping to get this functionality in trackpy for a long time.

Would you consider putting this pull request against the upstream fork at https://github.com/soft-matter/trackpy where all the contributors can review it?

@danielballan
Copy link

P.S. @nkeim I had forgotten that I started watching your fork before we joined forces. :- )

@nkeim
Copy link
Owner

nkeim commented Nov 7, 2015

Hi @danielballan ! I'm actually advising @dwieker on his senior project, so our plan was to discuss the code here before it goes over to the main repo. But your comments are welcome here or anywhere!

@danielballan
Copy link

Wonderful. I thought I might be missing some offline conversation here, but I can't resist the opportunity to welcome new potential contributors. Welcome, @dwieker!

@nkeim
Copy link
Owner

nkeim commented Nov 7, 2015

@dwieker This PR should be targeting the "master" branch. (It's confusing because the "numba" branch is the default on my fork, for historical reasons.) But if that proves difficult I can still do some code review here.

nkeim pushed a commit that referenced this pull request Feb 20, 2016
nkeim pushed a commit that referenced this pull request Oct 3, 2016
TST: Fix sorting in tests for pandas 0.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants