Cryptography 37.0.4 #680
Merged
Cryptography 37.0.4 #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `null` hash is used, a cryptic error is printed for unknown versions: > unpacking source archive > do not know how to unpack source archive With fakeHash, the build continues and we can see an actual hash mismatch error: > error: hash mismatch in fixed-output derivation '/nix/store/m95mjg0rf1w1x6qrxby4dajy3shvn2r9-cryptography-37.0.4-vendor.tar.gz.drv': > specified: sha256-AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA= > got: sha256-f8r6QclTwkgK20CNe9i65ZOqvSUeDc4Emv6BFBhh1hI=
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #679 (comment) for why I have removed 37.0.4
Also see openssl/openssl@6677e45 for the actual regression that actually brings down the whole application when ran an a sufficiently new CPU.
Also improved the error message for unknown versions to make updating cryptography easier in the future.