Remove dontPreferSetupPy & don't remove pyproject.toml #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f89dad to
7c141b7
Compare
|
This is somewhat related to #466 which I think I have changed my opinion on and will tackle soon. |
2cadca3 to
5485265
Compare
It seems like this bandaid to avoid some build-system related overrides causes more problems than it fixes. Let's just deal with reality up-front and hope that python-poetry/poetry#2789 will be fixed at some point.
f08dcc4 to
d263731
Compare
d263731 to
ff4c1b9
Compare
These packages uses poetry2nix and we can use them for regression testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like this bandaid to avoid some build-system related overrides causes more problems than it fixes.
Let's just deal with reality up-front and hope that python-poetry/poetry#2789 will be fixed at some point.
Additionally this results in much better error messages since you will be told exactly what input is missing.
With the faulty version detection you are simply told "the version is none".