Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not showing error when file ends with a comma #483

Closed
Libadoxon opened this issue Apr 29, 2024 · 1 comment · Fixed by #506
Closed

Not showing error when file ends with a comma #483

Libadoxon opened this issue Apr 29, 2024 · 1 comment · Fixed by #506
Labels
bug Something isn't working libnixf:parse The nixf parser

Comments

@Libadoxon
Copy link

Nixd does not show an error when a file ends with a comma
@inclyc
Copy link
Member

inclyc commented Apr 29, 2024 •
edited
Loading

This is expected. Currently the parser gets stopped at the first token it cannot recognize indeed it should trigger some error, but not yet implemented, fixes might be available soon.

@inclyc inclyc added bug Something isn't working libnixf:parse The nixf parser labels Apr 29, 2024
@inclyc inclyc mentioned this issue May 18, 2024
Closed
inclyc added a commit that referenced this issue May 23, 2024
@inclyc
libnixf: report error if extra token is consumed
b9f5af7 
Fixes: #483
@inclyc inclyc mentioned this issue May 23, 2024
Merged
inclyc added a commit that referenced this issue May 23, 2024
@inclyc
libnixf: report error if extra token is consumed (#506)
1027307 
Fixes: #483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working libnixf:parse The nixf parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

libnixf: report error if extra token is consumed nix-community/nixd
2 participants
@inclyc @Libadoxon