xdg-mime: add module #905
xdg-mime: add module #905
Conversation
|
Note that using |
modules/misc/xdg-mime.nix
Outdated
| ]; | ||
|
|
||
| home.sessionVariables = { | ||
| XDG_DATA_DIRS = "$XDG_DATA_DIRS:${config.home.profileDirectory}/share"; |
There was a problem hiding this comment.
I believe this belongs in nix.sh or some place where it is set for all people using Nix on non-NixOS, not just people using Home Manager.
There was a problem hiding this comment.
I tend to agree; unfortunately Eelco seems to think otherwise: NixOS/nix#2443
Perhaps the simplest solution here would be to wrap just xdg-open etc. instead in nixpkgs, analogously to NixOS/nixpkgs#54525?
There was a problem hiding this comment.
Fair enough, but it should only be set for people on non-NixOS since otherwise the ${config.home.profileDirectory}/share will show up twice. I would suggest to remove this for now and I'll make sure to re-add it in a later commit once I've figured out how to do it nicely. I would also place this somewhere else, perhaps in misc/xdg.nix since the variable isn't specifically related to xdg-mime.
There was a problem hiding this comment.
Ok, removed. I'll open a PR against xdg-open in nixpkgs to include XDG_DATA_DIRS there for everyone.
There was a problem hiding this comment.
I'm not sure how to do this in a nice way in a xdg-open wrapper since you can't at package build time know where the user profile will be found.
There was a problem hiding this comment.
Ah, you're right of course.
modules/misc/news.nix
Outdated
| message = '' | ||
| A new module is available: 'xdg.mime'. | ||
|
|
||
| If enabled, this module will create the XDG mime database |
There was a problem hiding this comment.
Should indicate that the module is enabled by default. Perhaps something like
| If enabled, this module will create the XDG mime database | |
| If enabled, which it is by default, this module will create the XDG mime database |
suffices?
There was a problem hiding this comment.
Ah, good catch. I think I wasn't sure whether it should even be enabled by default, but it seems you don't mind. The commands' execution time does seem to be negligible.
There was a problem hiding this comment.
My spontaneous reaction was that it should be disabled by default but I think it should be fine since the NixOS module seems to be enabled by default and I haven't heard any complaints about that.
|
Thanks! I've rebased this to master in 571989f. |
This is a direct translation of the NixOS module.
If enabled, this module will create the XDG mime database
and desktop file database caches from programs installed
via home-manager. The 'XDG_DATA_DIRS' environment variable
is extended so that programs like 'xdg-open' can find and
make use of these databases.
Not sure if it makes sense to add a test here; the files are auto-generated, big, and one of them even uses a binary format.