Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-cursor.nix: enable gtk module when enabling gtk config generation #4144

Merged
merged 4 commits into from
Jul 14, 2023
Merged

home-cursor.nix: enable gtk module when enabling gtk config generation #4144

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fd9d4df
home-cursor.nix: enable gtk module when enabling gtk config generation
Maroka-chan Jun 22, 2023
da18a6e
home-cursor.nix: Add note to gtk config generation description instea…
Maroka-chan Jul 9, 2023
e35a418
home-cursor.nix: Add note about applying pointerCursor configs to mai…
Maroka-chan Jul 11, 2023
e3f63be
home-cursor.nix: Change tabs to spaces
Maroka-chan Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/config/home-cursor.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ let

gtk = {
enable = mkEnableOption ''
gtk config generation for <option>home.pointerCursor</option>
gtk config generation for <option>home.pointerCursor</option>.
Note that <option>gtk</option> has to be enabled for the configs to take effect
Copy link
Contributor

@polykernel polykernel Jul 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be worthwhile to add a clause under the main home.pointerCursor submodule's description since the same requirement holds for the x11 backend and xsession.enable.

Perhaps something akin to

description = ''
  Cursor configuration. Set to <literal>null</literal> to disable.
  </para><para>
  Top-level options declared under this submodule are backend independent
  options. Options declared under namespaces such as <literal>x11</literal>
  are backend specific options. By default, only backend independent cursor
  configurations are generated. If you need configurations for specific
  backends, you can toggle them via the enable option. For example,
  <xref linkend="opt-home.pointerCursor.x11.enable"/>
  will enable x11 cursor configurations.
  </para><para>
  Note that the cursor configurations are only generated, the relevant
  subsytems still must be configured for them to take effect. For example,
  <xref linkend="opt-home.pointerCursor.gtk.enable"/> will enable
  gtk cursor configuration but <xref linkend="opt-gtk.enable"/> needs
  to be set for it to be applied.
'';

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I've now removed the note on the gtk option and added the more general note under the main submodule description :)

'';
};
};
Expand Down