Skip to content

Commit

Permalink
Use tracing with default features because it works
Browse files Browse the repository at this point in the history
  • Loading branch information
kolloch committed Nov 24, 2019
1 parent 298533c commit ffc06fd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion sample_projects/with_problematic_crates/Cargo.nix
Original file line number Diff line number Diff line change
Expand Up @@ -5997,6 +5997,7 @@ rec {
"log-always" = [ "log" ];
"std" = [ "tracing-core/std" ];
};
resolvedDefaultFeatures = [ "default" "std" ];
};
"tracing-attributes 0.1.5 (registry+https://github.com/rust-lang/crates.io-index)"
= rec {
Expand Down Expand Up @@ -6053,6 +6054,7 @@ rec {
features = {
"default" = [ "std" ];
};
resolvedDefaultFeatures = [ "std" ];
};
"trust-dns-proto 0.7.4 (registry+https://github.com/rust-lang/crates.io-index)"
= rec {
Expand Down Expand Up @@ -6828,7 +6830,6 @@ rec {
{
name = "tracing";
packageId = "tracing 0.1.9 (registry+https://github.com/rust-lang/crates.io-index)";
usesDefaultFeatures = false;
}
];
features = {
Expand Down
2 changes: 1 addition & 1 deletion sample_projects/with_problematic_crates/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ tokio-threadpool = "*"
# tokio-executor + tracing triggers the use of cfg(feature = "...")
tokio-executor = "*"
# FIXME: using default features causes 2 versions of lazy_static to be found
tracing = { version = "*", default-features = false }
tracing = "*"

1 comment on commit ffc06fd

@cpcloud
Copy link
Contributor

@cpcloud cpcloud commented on ffc06fd Nov 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I swear this wasn't compiling for me because of #51.

Please sign in to comment.