feat: (draghandle) drag handle implementation #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivekcode
reviewed
Oct 13, 2021
| ); | ||
| }); | ||
|
|
||
| it('hould create an instance', () => { |
There was a problem hiding this comment.
should be "should" and not "hould"
nivekcode
reviewed
Oct 13, 2021
| this.handleElement = this.handle?.el?.nativeElement || this.el.nativeElement; | ||
|
|
||
| fromEvent<DragEvent>(this.handleElement, 'mousedown').pipe( | ||
| takeUntil(this.destroy$) |
There was a problem hiding this comment.
Very nice 👍 This takeUntil is important!
|
Hi @Alessy. Wow. Thx a lot. The changes look good. I left one small comment because of a typo. Would be great if you could fix this typo and then we can merge. Great work 👍 |
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
==========================================
- Coverage 93.93% 93.40% -0.54%
==========================================
Files 9 10 +1
Lines 264 273 +9
Branches 25 26 +1
==========================================
+ Hits 248 255 +7
- Misses 16 18 +2
Continue to review full report at Codecov.
|
nivekcode
approved these changes
Oct 13, 2021
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drag handle implementation (like cdkDragHandle).
I and a few people wanted this feature, so here it is :)
The only problem is that I don't know how to write test scenarios in ngsg-item.directive.spec.ts