-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: switch globby to tinyglobby #3108
base: v2
Are you sure you want to change the base?
Conversation
I appreciate the PR. I'm aware of tinyglobyy and we are progressively migrating to it (or alternatives) across unjs, however it has a big difference from globby where it does not have integration with npm This lack of feature had caused significant runtime performance regressions (with unbuild/mkdist for one instance) which was far beyond the small install size benefits, therefore I want to be careful about migration. Do you think we can either followup this first in upstream or help making an internal util that uses tinyglobby+ignore? |
Oh, that's good to know! I wasn't aware that it was causing performance issues that you'd run into. I've filed an issue upstream and will check to see what the tinyglobby author thinks: SuperchupuDev/tinyglobby#92 |
FYI many performance issues were solved with the release of 0.2.11 which happened this week |
I do know that the one nuxt performance issue I saw was reported as being fixed with 0.2.11: nuxt/nuxt#30137 @pi0 would you be able to check if it fixes your issue too or whether the |
(will test and confirm locally) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All is good in terms of gitignore support (globby seems was opt-in so not breaking)
The only remaining issue is negated support for ignore (see fixture and test) ~> pending SuperchupuDev/tinyglobby#70
π Linked issue
β Type of change
π Description
https://npmgraph.js.org/?q=globby - 23 dependencies
https://npmgraph.js.org/?q=tinyglobby - 2 dependencies
π Checklist