Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: increase generated tsconfig.json strictness #2533

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This is a remake of #2532, but for main branch... (Just close whichever PR is not relevant.)

This increases strictness for the generated tsconfig.json. The most significant change, I think, is noUncheckedIndexedAccess - feel free to remove if you think this is too much! (But of course it can always be disabled by end user.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 June 14, 2024 22:09
@danielroe danielroe self-assigned this Jun 14, 2024
@danielroe danielroe changed the base branch from v2 to main June 14, 2024 22:09
@danielroe danielroe changed the title Chore/tsconfig main feat: increase generated tsconfig.json strictness Jun 14, 2024
@pi0 pi0 changed the title feat: increase generated tsconfig.json strictness feat!: increase generated tsconfig.json strictness Jun 17, 2024
@pi0 pi0 merged commit 7e0b49e into main Jun 17, 2024
1 check passed
@pi0 pi0 deleted the chore/tsconfig-main branch June 17, 2024 09:59
@pi0 pi0 mentioned this pull request Jun 17, 2024
17 tasks
davidstackio pushed a commit to davidstackio/nitro that referenced this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants