Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gcp): Support topic imports for GCP. #722

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Conversation

tjholm
Copy link
Member

@tjholm tjholm commented Jan 17, 2025

No description provided.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.

Project coverage is 48.75%. Comparing base (b74d46b) to head (2a79150).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cloud/gcp/runtime/gateway/http.go 55.55% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
- Coverage   48.91%   48.75%   -0.16%     
==========================================
  Files          28       28              
  Lines        3549     3546       -3     
==========================================
- Hits         1736     1729       -7     
- Misses       1695     1698       +3     
- Partials      118      119       +1     
Flag Coverage Δ
aws 44.89% <ø> (ø)
azure 53.29% <ø> (ø)
core 60.76% <ø> (ø)
gcp 47.14% <55.55%> (-0.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Ryan Cartwright <39504851+HomelessDinosaur@users.noreply.github.com>
@tjholm tjholm merged commit 137a528 into main Jan 21, 2025
4 checks passed
@tjholm tjholm deleted the fix/gcp-topic-imports branch January 21, 2025 21:29
@nitric-bot
Copy link

🎉 This PR is included in version 1.16.13 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants