-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View-backed annotations #404
Comments
Anyone have an idea to where we can start to implement this? I'm transitioning from react-native-maps which had this feature. |
@xvalentino So the only way that I can see is use remote images if we want to customize annotations. Maybe we could add some interfaces to transfer some data to display. BUT the url image still not work on Android #391. |
+1 for this feature |
+1 |
Looks like iOS SDK master already has this feature. When we could expect usage of React Native Views for annotations? |
If I understand correctly, the RNMBGL component isn’t currently designed to function as a container for other views rendered by React Native. This will prevent RNMBGL from being able to take direct advantage of the view-backed annotation support added in mapbox/mapbox-gl-native#4801 for mapbox/mapbox-gl-native#1784. I don’t know if this is a fundamental limitation of React Native or just an enhancement that will need to be made to RNMBGL, but there definitely isn’t a timetable for bringing this feature over to React Native yet. If you need view-backed annotations in the meantime and don’t mind writing your application in (truly) native iOS technologies, I’d recommend using the Mapbox iOS SDK directly in Objective-C or Swift. |
It’s the same story on Android, where the Mapbox Android SDK also supports view-backed markers, but RNMBGL would have to work like a container somehow. |
@1ec5 I don't see any fundamental problem to support custom views, like react-native-maps package does with native MapView. I would like to try, will you accept PR when it will be finished? |
As of #421, arbitrary React Native views can be used as view-backed annotations on iOS. #423 takes a markedly different approach for Android. Instead of arbitrary React Native views, the developer specifies the usual annotation options (plus a few more) and those options are implemented using MarkerViews. |
…escript Typescript definitions for updated VectorSource / RasterSource
Hi, thanks for the repo.
But I found it's really inconvenient that we can't customize annotations.
So hope to add this feature. Thank you!
The text was updated successfully, but these errors were encountered: