Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ShiftRows destroys merged cell issue #877

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Fix ShiftRows destroys merged cell issue #877

merged 3 commits into from
Jul 20, 2022

Conversation

tonyqus
Copy link
Member

@tonyqus tonyqus commented Jul 14, 2022

  • sync ShiftRows logic from POI 5.2
  • fix merged region overlap issue

@tonyqus tonyqus added this to the NPOI 2.6.0 milestone Jul 14, 2022
@tonyqus tonyqus changed the title Shiftrows mergedcell Fix ShiftRows destroys merged cell issue Jul 14, 2022
@tonyqus tonyqus mentioned this pull request Jul 14, 2022
Closed
@serii833
Copy link

I wanted to give it a try but solution doesn't compile
with an error
npoi/main/SS/Formula/PTG/FormulaShifter.cs could not be found

@tonyqus
Copy link
Member Author

tonyqus commented Jul 15, 2022

@serii833 I forgot changing the non-Core csproj files. Can you try again?

@serii833
Copy link

@tonyqus looks good on my samples

@tonyqus tonyqus merged commit 24dd55a into master Jul 20, 2022
@tonyqus tonyqus deleted the shiftrows_mergedcell branch August 23, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
xls xlsx
Projects
None yet
Milestone
NPOI 2.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyqus @serii833