Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POI Bug 69154: Shifting columns with merged regions generates an error about overlapping regions #1438

Closed
wants to merge 1 commit into from

Conversation

TimLee88
Copy link
Contributor

Synchronize from apache poi

Fix #962

@Bykiev
Copy link
Collaborator

Bykiev commented Nov 2, 2024

Hi, thanks for contribution, can you please add the test case?
apache/poi@e1c6168

POI Bug 69154

@tonyqus tonyqus changed the title Update RowShifter.cs POI Bug 69154: Update RowShifter.cs Nov 7, 2024
@tonyqus tonyqus added this to the NPOI 2.7.3 milestone Nov 7, 2024
@tonyqus
Copy link
Member

tonyqus commented Nov 8, 2024

@TimLee88 #1329 merge looks to contain the fix from POI Bug 69154. But there is some code difference. Can you help review the conflict?

@tonyqus tonyqus changed the title POI Bug 69154: Update RowShifter.cs POI Bug 69154: Shifting columns with merged regions generates an error about overlapping regions Nov 8, 2024
Copy link
Contributor Author

@TimLee88 TimLee88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code works fine in my program

@TimLee88 TimLee88 closed this Nov 19, 2024
@TimLee88 TimLee88 deleted the T4 branch November 19, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ShiftMergedRegions throws ArgumentException("lastRow < firstRow || lastCol < firstCol")
3 participants