Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE issue in PackageRelationshipCollection #1330

Merged
merged 1 commit into from
May 4, 2024
Merged

Fix NPE issue in PackageRelationshipCollection #1330

merged 1 commit into from
May 4, 2024

Conversation

tonyqus
Copy link
Member

@tonyqus tonyqus commented May 4, 2024 •
edited
Loading

sync code from apache/poi@cdb2ba1

fix #1229

@tonyqus tonyqus requested a review from Bykiev May 4, 2024 05:57
@tonyqus tonyqus changed the title Fix #1229 Fix NPE issue May 4, 2024
@tonyqus tonyqus changed the title Fix NPE issue Fix NPE issue in PackageRelationshipCollection May 4, 2024
Bykiev
Bykiev approved these changes May 4, 2024
View reviewed changes
Copy link
Collaborator

@Bykiev Bykiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should focus on tests, many of them are failing

@tonyqus
Copy link
Member Author

tonyqus commented May 4, 2024

@Bykiev I checked the test cases. The failure is caused by #1287

@tonyqus tonyqus merged commit 3381d73 into nissl-lab:master May 4, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bykiev Bykiev Bykiev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Several possible NPE
2 participants
@tonyqus @Bykiev