Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checking if cell is locked #1125

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Fix checking if cell is locked #1125

merged 4 commits into from
Jul 27, 2023

Conversation

Bykiev
Copy link
Collaborator

@Bykiev Bykiev commented Jul 24, 2023

This PR closes #738

@Bykiev Bykiev marked this pull request as draft July 24, 2023 14:18
@Bykiev Bykiev marked this pull request as ready for review July 24, 2023 14:34
@Bykiev Bykiev marked this pull request as draft July 24, 2023 16:55
@Bykiev
Fix
3ee810b 
By default locked property is true and not specified in protection element
@Bykiev Bykiev marked this pull request as ready for review July 24, 2023 19:36
@tonyqus
Copy link
Member

tonyqus commented Jul 27, 2023

LGTM

@tonyqus tonyqus added this to the NPOI 2.7.0 milestone Jul 27, 2023
@tonyqus tonyqus merged commit 4046e09 into nissl-lab:master Jul 27, 2023
@tonyqus tonyqus modified the milestones: NPOI 2.7.0, NPOI 2.6.2 Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug xlsx
Projects
None yet
Milestone
NPOI 2.6.2
Development

Successfully merging this pull request may close these issues.

Writing to locked cell results in cell being unlocked and workbook structure protection being lost
2 participants
@Bykiev @tonyqus