Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Countifs fail to evaluate correctly #825 #1115

Merged
merged 1 commit into from
Jul 9, 2023
Merged

Countifs fail to evaluate correctly #825 #1115

merged 1 commit into from
Jul 9, 2023

Conversation

deleteJ
Copy link
Contributor

@deleteJ deleteJ commented Jul 9, 2023

  1. This closes Countifs fail to evaluate correctly #825 (porting Baseifs from POI)
  2. add Countifs test case to track multi rows scenario

@deleteJ
1. add Countifs test case to track issue825
eddcf35 
2. modify CountIfs.cs, to close issue#825 Countifs fail to evaluate correctly
@tonyqus
Copy link
Member

tonyqus commented Jul 9, 2023

LGTM

@tonyqus tonyqus merged commit 29f23d6 into nissl-lab:master Jul 9, 2023
@tonyqus tonyqus added the bug label Jul 9, 2023
@tonyqus tonyqus added this to the NPOI 2.7.0 milestone Jul 9, 2023
@tonyqus
Copy link
Member

tonyqus commented Jul 13, 2023

You can use https://github.com/nissl-lab/JavaToCSharp tool to do conversion from Java to C# automatically.

@tonyqus tonyqus modified the milestones: NPOI 2.7.0, NPOI 2.6.2 Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug formula
Projects
None yet
Milestone
NPOI 2.6.2
Development

Successfully merging this pull request may close these issues.

Countifs fail to evaluate correctly
2 participants
@deleteJ @tonyqus