Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Remove deprecated np.float usage #3341

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Conversation

effigies
Copy link
Member

Wanted to run this one by people rather than tucking into #3336.

Because np.float is just __builtins__.float, which is in turn promoted to np.float64 when used as a dtype, this should have no effect. Just want to make sure that this is what's intended in these cases.

@codecov
Copy link

codecov bot commented May 30, 2021

Codecov Report

Merging #3341 (cbc1824) into master (d02750a) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3341   +/-   ##
=======================================
  Coverage   65.01%   65.01%           
=======================================
  Files         302      302           
  Lines       40035    40035           
  Branches     5291     5291           
=======================================
  Hits        26029    26029           
  Misses      12935    12935           
  Partials     1071     1071           
Flag Coverage Δ
unittests 64.79% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/algorithms/rapidart.py 34.42% <0.00%> (ø)
nipype/algorithms/modelgen.py 59.25% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d02750a...cbc1824. Read the comment docs.

@effigies effigies added this to the 1.6.1 milestone May 30, 2021
@effigies effigies merged commit 97f2127 into nipy:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant