Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: No longer depending on pydotplus (networkx >=2.0 update) #3251

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

TheChymera
Copy link
Collaborator

@TheChymera TheChymera commented Sep 17, 2020

@effigies

Fixes: #3244

didn't commit after running make check-before-commit because it changes a lot of files with what appear to be unrelated changes.
Also it fails with:

chymera@silenthost ~/src/nipype $ make check-before-commit
Checking specs and autogenerating spec tests
env PYTHONPATH=".:" python tools/checkspecs.py
CompCor has nonautotest
TSNR has nonautotest
200917-12:08:45,637 nipype.interface WARNING:
	 VTK was not found
200917-12:08:45,638 nipype.interface WARNING:
	 tvtk wasn't found
ErrorMap has nonautotest
Overlap has nonautotest
Overlap has nonautotest
TSNR has nonautotest
200917-12:08:52,951 nipype.interface INFO:
	 We advise you to upgrade DIPY version. This upgrade will open access to more function
200917-12:08:52,953 nipype.interface INFO:
	 We advise you to upgrade DIPY version. This upgrade will open access to more function
200917-12:08:52,955 nipype.interface INFO:
	 We advise you to upgrade DIPY version. This upgrade will open access to more models
FSSurfaceCommand has nonautotest
BBRegister has nonautotest
FILMGLS has nonautotest
Traceback (most recent call last):
  File "tools/checkspecs.py", line 522, in <module>
    ic.check_modules()
  File "tools/checkspecs.py", line 475, in check_modules
    bad_specs = self.test_specs(m)
  File "tools/checkspecs.py", line 230, in test_specs
    __import__(uri)
  File "/home/chymera/src/nipype/nipype/sphinxext/apidoc/__init__.py", line 5, in <module>
    from sphinxcontrib.napoleon import (
ModuleNotFoundError: No module named 'sphinxcontrib.napoleon'
make: *** [Makefile:73: specs] Error 1

I know I ran into this before, maybe this is another unnecessary dep best fixed in another PR.

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@TheChymera
Copy link
Collaborator Author

@effigies ^ ?

@effigies
Copy link
Member

Pushed a commit to master that I think should fix the test failures. If everything's green, feel free to rebase on that.

@effigies
Copy link
Member

Test failures fixed on master.

@TheChymera
Copy link
Collaborator Author

@effigies rebased, but the circleci tests seem to still fail. Any ideas why? They look like permission errors, no idea how that could be related to the PR....

@effigies
Copy link
Member

Not sure. My guess is there's something weird with running CircleCI on your own fork, rather than as a PR on nipy. But Travis is passing, so let's go ahead with this. If there's a continued problem with Circle, we can address it when it reproduces on nipy.

@effigies effigies merged commit 929de35 into nipy:master Sep 18, 2020
@effigies effigies added this to the 1.6.0 milestone May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pydotplus dependency
2 participants