Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: test_no_et hanging on Python 3.8 #3239

Merged
merged 3 commits into from
Aug 15, 2020

Conversation

effigies
Copy link
Member

Summary

Travis is consistently hanging on Python 3.8, apparently at test_no_et. This adds verbosity, and splits up the test to hopefully make it easier to track down.

Cannot reproduce this locally by running the specific file, but there may be state changes in the test workers...

List of changes proposed in this PR (pull-request)

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov
Copy link

codecov bot commented Aug 15, 2020

Codecov Report

Merging #3239 into maint/1.5.x will increase coverage by 0.03%.
The diff coverage is 87.50%.

Impacted file tree graph

@@               Coverage Diff               @@
##           maint/1.5.x    #3239      +/-   ##
===============================================
+ Coverage        64.96%   64.99%   +0.03%     
===============================================
  Files              302      302              
  Lines            39929    39942      +13     
  Branches          5279     5282       +3     
===============================================
+ Hits             25939    25962      +23     
+ Misses           12925    12919       -6     
+ Partials          1065     1061       -4     
Flag Coverage Δ
#unittests 64.99% <87.50%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/interfaces/io.py 56.41% <ø> (ø)
nipype/interfaces/ants/utils.py 88.94% <86.66%> (-0.33%) ⬇️
nipype/conftest.py 96.15% <100.00%> (+0.15%) ⬆️
nipype/algorithms/misc.py 45.12% <0.00%> (-0.12%) ⬇️
nipype/pipeline/plugins/base.py 59.72% <0.00%> (+1.64%) ⬆️
nipype/pipeline/plugins/legacymultiproc.py 69.11% <0.00%> (+3.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c71b8ac...7400725. Read the comment docs.

@effigies
Copy link
Member Author

Unclear why this fixed the hanging, but I guess at least we can get through tests.

@effigies effigies merged commit 02d1500 into nipy:maint/1.5.x Aug 15, 2020
@effigies effigies deleted the fix/no_et_38_failure branch August 15, 2020 13:27
@effigies effigies added this to the 1.5.1 milestone Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant