-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh/readthedocs #3207
Enh/readthedocs #3207
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3207 +/- ##
=======================================
Coverage 64.89% 64.89%
=======================================
Files 301 301
Lines 39717 39717
Branches 5268 5268
=======================================
+ Hits 25775 25776 +1
Misses 12884 12884
+ Partials 1058 1057 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
unfortunately still failing on readthedocs. https://readthedocs.org/projects/nipype/builds/10866072/ |
Oh, the issue is that installing niflow-nipype1-workflows is installing nipype from PyPI. I'm going to fiddle with the RTD yaml directly on master so we get some feedback from readthedocs. |
aha. thanks @effigies |
Got most of the way, and then failed on the We haven't been rendering up to now, so I've just blacklisted it from being copied in a10d3da. |
PDF is problematic: https://readthedocs.org/projects/nipype/builds/10866371/ I assume EPUB is no less so. If we want to get these built, let's open issues to work on them. |
sounds good. |
adds the preferred way to set readthedocs settings for building the docs.
currently readthedocs is still failing in master with the same alt error.