Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh/readthedocs #3207

Merged
merged 2 commits into from
Apr 18, 2020
Merged

Enh/readthedocs #3207

merged 2 commits into from
Apr 18, 2020

Conversation

satra
Copy link
Member

@satra satra commented Apr 18, 2020

adds the preferred way to set readthedocs settings for building the docs.

currently readthedocs is still failing in master with the same alt error.

@codecov
Copy link

codecov bot commented Apr 18, 2020

Codecov Report

Merging #3207 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3207   +/-   ##
=======================================
  Coverage   64.89%   64.89%           
=======================================
  Files         301      301           
  Lines       39717    39717           
  Branches     5268     5268           
=======================================
+ Hits        25775    25776    +1     
  Misses      12884    12884           
+ Partials     1058     1057    -1     
Flag Coverage Δ
#unittests 64.89% <ø> (+<0.01%) ⬆️
Impacted Files Coverage Δ
nipype/pipeline/engine/utils.py 71.72% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28ef1af...d3a965c. Read the comment docs.

Copy link
Contributor

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satra satra merged commit c49e2fe into master Apr 18, 2020
@satra
Copy link
Member Author

satra commented Apr 18, 2020

unfortunately still failing on readthedocs. https://readthedocs.org/projects/nipype/builds/10866072/
i will walk away for a bit. (@effigies and @oesteban if you have any ideas, let me know).

@effigies
Copy link
Member

Oh, the issue is that installing niflow-nipype1-workflows is installing nipype from PyPI.

I'm going to fiddle with the RTD yaml directly on master so we get some feedback from readthedocs.

@satra
Copy link
Member Author

satra commented Apr 18, 2020

Oh, the issue is that installing niflow-nipype1-workflows is installing nipype from PyPI.

aha. thanks @effigies

@effigies
Copy link
Member

Got most of the way, and then failed on the nipype_tutorial.ipynb example: https://readthedocs.org/projects/nipype/builds/10866330/

We haven't been rendering up to now, so I've just blacklisted it from being copied in a10d3da.

@effigies effigies deleted the enh/readthedocs branch April 18, 2020 20:58
@effigies
Copy link
Member

PDF is problematic: https://readthedocs.org/projects/nipype/builds/10866371/

I assume EPUB is no less so. If we want to get these built, let's open issues to work on them.

@satra
Copy link
Member Author

satra commented Apr 18, 2020

sounds good.

@effigies effigies added this to the 1.5.0 milestone Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants