FIX: Partial rollback of N4BiasFieldCorrection #3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the last maintenance (nipy#3180) of the interface, we eliminated an important section of the ``_list_outputs``: nipy@6979cbd#diff-b6f33a19b0e06b91023416db5faf7323L544-L547 This PR addresses the problem: ``` Execution Outputs ----------------- * bias_image : <undefined> * output_image : /home/oesteban/tmp/fmriprep-ds005/fprep-work/fmriprep_wf/single_subject_01_wf/anat_preproc_wf/brain_extraction_wf/inu_n4_final/mapflow/_inu_n4_final0/sub-01_T1w_cor rected.nii.gz Runtime info ------------ * cmdline : N4BiasFieldCorrection --bspline-fitting [ 200 ] -d 3 --input-image /oak/stanford/groups/russpold/data/openfmri/ds000005/sub-01/anat/sub-01_T1w.nii.gz --convergence [ 50x 50x50x50x50, 1e-07 ] --output [ sub-01_T1w_corrected.nii.gz, sub-01_T1w_bias.nii.gz ] -r --shrink-factor 4 --weight-image /home/oesteban/tmp/fmriprep-ds005/fprep-work/fmriprep_wf/single_subject_01_wf/anat_preproc_wf/brain_extraction_wf/atropos_wf/copy_xform/09_relabel_wm_maths_xform.nii.gz * duration : 15.334786 * hostname : dendrite * prev_wd : /home/oesteban/tmp/fmriprep-ds005 * working_dir : /home/oesteban/tmp/fmriprep-ds005/fprep-work/fmriprep_wf/single_subject_01_wf/anat_preproc_wf/brain_extraction_wf/inu_n4_final/mapflow/_inu_n4_final0 ``` (`bias_image` should be `'sub-01_T1w_bias.nii.gz'` given the `cmdline`)
Codecov Report
@@ Coverage Diff @@
## master #3188 +/- ##
==========================================
- Coverage 65.08% 64.23% -0.85%
==========================================
Files 301 299 -2
Lines 39619 39542 -77
Branches 5246 5237 -9
==========================================
- Hits 25785 25400 -385
- Misses 12767 13085 +318
+ Partials 1067 1057 -10
Continue to review full report at Codecov.
|
|
Tested locally 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last maintenance (#3180) of the interface, we eliminated an
important section of the
_list_outputs:6979cbd#diff-b6f33a19b0e06b91023416db5faf7323L544-L547
This PR addresses the problem:
(
bias_imageshould be'sub-01_T1w_bias.nii.gz'given thecmdline)Summary
Fixes # .
List of changes proposed in this PR (pull-request)
Acknowledgment