Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Prefer math.gcd to hand-rolled Euclid's algorithm #3177

Merged
merged 2 commits into from
Feb 25, 2020

Conversation

effigies
Copy link
Member

Summary

Fixes #3125.

List of changes proposed in this PR (pull-request)

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #3177 into master will increase coverage by 0.02%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3177      +/-   ##
==========================================
+ Coverage   64.85%   64.88%   +0.02%     
==========================================
  Files         299      299              
  Lines       39510    39506       -4     
  Branches     5220     5219       -1     
==========================================
+ Hits        25623    25632       +9     
+ Misses      12832    12824       -8     
+ Partials     1055     1050       -5
Flag Coverage Δ
#unittests 64.88% <75%> (+0.02%) ⬆️
Impacted Files Coverage Δ
nipype/algorithms/modelgen.py 59.25% <75%> (-0.36%) ⬇️
nipype/pipeline/plugins/base.py 58.9% <0%> (+1.64%) ⬆️
nipype/pipeline/plugins/legacymultiproc.py 68.81% <0%> (+3.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9049156...7a19ee0. Read the comment docs.

@effigies effigies added this to the 1.5.0 milestone Feb 24, 2020
@effigies
Copy link
Member Author

Given that we're waiting on some responses from other PRs and an assessment of what's up with the tutorials, might as well squeeze this into 1.5.0.

Anybody have a minute for a review?

Copy link
Member

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on removing unnecessary code

@effigies
Copy link
Member Author

Thanks for the review.

@effigies effigies merged commit b75a7ce into nipy:master Feb 25, 2020
@effigies effigies deleted the rf/gcd branch February 25, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace gcd with math.gcd (Python 3.5+)
2 participants